OZ-336: Added E2E tests beyond data count in Superset tables #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaud
changed the title
kdaud
changed the title
kdaud
changed the title
kdaud
changed the title
kdaud
changed the title
kdaud
force-pushed
the
OZ-336
branch
3 times, most recently
from
eff286c to
3946e9a
Compare
kdaud
changed the title
kdaud
changed the title
|
@Ruhanga, this PR is ready for review. |
kdaud
changed the title
kdaud
changed the title
Ruhanga
requested changes
Oct 23, 2023
|
|
||
| await page.getByRole('tab', { name: 'Query history' }).click(); | ||
| await homePage.clearSQLEditor(); | ||
| let sqlQuerry2 = `SELECT * FROM patients WHERE given_name like '${patientName.firstName}' AND family_name like '${patientName.givenName}';`; |
There was a problem hiding this comment.
I'd name this variable sqlQuery or explicitly patientQuery
|
|
||
| await page.getByRole('tab', { name: 'Query history' }).click(); | ||
| await homePage.clearSQLEditor(); | ||
| let sqlQuery2 = `SELECT patient_id FROM patients WHERE given_name like '${patientName.firstName}' AND family_name like '${patientName.givenName}';`; |
|
|
||
| await page.getByRole('tab', { name: 'Query history' }).click(); | ||
| await homePage.clearSQLEditor(); | ||
| let sqlQuery2 = `SELECT patient_id FROM patients WHERE given_name like '${patientName.firstName}' AND family_name like '${patientName.givenName}';`; |
There was a problem hiding this comment.
Same here, or more explicitly patientIdQuery.
| const patientIdValue = Number(patientId); | ||
| await page.getByRole('tab', { name: 'Results' }).click(); | ||
| await homePage.clearSQLEditor(); | ||
| let sqlQuery3 = `SELECT * FROM _orders WHERE patient_id=${patientIdValue};`; |
There was a problem hiding this comment.
I'd rename this to orderQuery.
mks-d
reviewed
Oct 23, 2023
| const updatedNumberOfPatients = await page.getByRole('gridcell', { name: ' ' }).nth(0).textContent(); | ||
| let updatedPatientCount = Number(updatedNumberOfPatients); | ||
|
|
||
| await expect(updatedPatientCount).toBeGreaterThan(initialPatientCount); |
There was a problem hiding this comment.
For patient you should actually check that it's a +1.
kdaud
changed the title
|
@Ruhanga I've adapted the Superset tests to retrieve test patient from patients table using OpenMRS ID. |
Ruhanga
requested changes
Oct 24, 2023
| await page.getByRole('textbox').first().clear(); | ||
| await page.getByRole('textbox').fill('SELECT COUNT (*) FROM visits;'); | ||
| await homePage.clearSQLEditor(); | ||
| let visitCountsQuery = `SELECT COUNT (*) FROM visits;` |
There was a problem hiding this comment.
visitCountsQuery ➙ visitsCountQuery
| const patientIdValue = Number(patientId); | ||
| await page.getByRole('tab', { name: 'Results' }).click(); | ||
| await homePage.clearSQLEditor(); | ||
| let visitQuery = `SELECT * FROM visits WHERE patient_id=${patientIdValue};`; |
There was a problem hiding this comment.
visitQuery ➙ patientVisitQuery
| await page.getByRole('textbox').first().clear(); | ||
| await page.getByRole('textbox').fill('SELECT COUNT(*) FROM _orders;'); | ||
| await homePage.clearSQLEditor(); | ||
| let orderCountsQuery = `SELECT COUNT(*) FROM _orders;` |
There was a problem hiding this comment.
orderCountsQuery ➙ ordersCountQuery
| await page.getByRole('textbox').first().clear(); | ||
| await page.getByRole('textbox').fill('SELECT COUNT(*) FROM encounters;'); | ||
| await homePage.clearSQLEditor(); | ||
| let encounterCountsQuery = `SELECT COUNT(*) FROM encounters;` |
There was a problem hiding this comment.
encounterCountsQuery ➙ encountersCountQuery
| await page.getByRole('textbox').first().clear(); | ||
| await page.getByRole('textbox').fill('SELECT COUNT (*) FROM _conditions;'); | ||
| await homePage.clearSQLEditor(); | ||
| let conditionCountsQuery = `SELECT COUNT (*) FROM _conditions;` |
There was a problem hiding this comment.
conditionCountsQuery ➙ conditionsCountQuery
Ruhanga
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket → OZ-336
Description → This PR adds E2E tests beyond data count in Superset tables verifying that;