Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ-437: Added ability to run Ozone PRO tests on a preferred environment via GitHub Actions #63

Merged
merged 5 commits into from
Dec 8, 2023
Merged

OZ-437: Added ability to run Ozone PRO tests on a preferred environment via GitHub Actions #63

merged 5 commits into from
Dec 8, 2023

Conversation

kdaud
Copy link
Contributor

@kdaud kdaud commented Nov 15, 2023 •
edited by jira bot
Loading

Ticket → OZ-437

@kdaud kdaud force-pushed the OZ-437 branch 4 times, most recently from 5a2cc46 to f632ea1 Compare November 16, 2023 18:50
@kdaud kdaud requested a review from Ruhanga November 20, 2023 07:08
Ruhanga
Ruhanga reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdaud, find a few comments below...

.env Outdated Show resolved Hide resolved
.github/workflows/runOzoneProTestsOnProvidedEnv.yml Outdated Show resolved Hide resolved
.github/workflows/runOzoneProTestsOnProvidedEnv.yml Outdated Show resolved Hide resolved
@kdaud kdaud requested a review from Ruhanga November 20, 2023 10:00
@kdaud kdaud force-pushed the OZ-437 branch 5 times, most recently from 979338a to 9172351 Compare November 21, 2023 07:03
@kdaud kdaud requested a review from Ruhanga November 21, 2023 13:46
@kdaud
Copy link
Contributor Author

kdaud commented Nov 24, 2023

@Ruhanga, I addressed the reviews, could there be more?

Ruhanga
Ruhanga reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kdaud just a few suggested changes.

e2e/tests/testAnalyticsIntegration.spec.ts Outdated Show resolved Hide resolved
e2e/tests/testAnalyticsIntegration.spec.ts Outdated Show resolved Hide resolved
e2e/tests/testAnalyticsIntegration.spec.ts Outdated Show resolved Hide resolved
e2e/tests/testOdooIntegration.spec.ts Outdated Show resolved Hide resolved
e2e/utils/functions/testBase.ts Show resolved Hide resolved
e2e/utils/functions/testBase.ts Outdated Show resolved Hide resolved
.github/workflows/runOzoneTestsOnSpecifiedEnv.yml Show resolved Hide resolved
@kdaud kdaud force-pushed the OZ-437 branch 7 times, most recently from 01e3519 to 16cb33c Compare December 5, 2023 10:52
@kdaud kdaud force-pushed the OZ-437 branch 2 times, most recently from ef8bcd6 to 4b5bf86 Compare December 5, 2023 11:02
@kdaud kdaud requested a review from Ruhanga December 5, 2023 11:05
@kdaud
Copy link
Contributor Author

kdaud commented Dec 6, 2023

@Ruhanga I've addressed all the reviews.

Ruhanga
Ruhanga reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ruhanga Ruhanga merged commit f62327d into main Dec 8, 2023
@kdaud kdaud deleted the OZ-437 branch December 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruhanga Ruhanga Ruhanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdaud @Ruhanga