Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ-336: Voiding an OpenMRS observation updates observations dataset in Superset #67

Merged
merged 3 commits into from
Mar 14, 2024
Merged

OZ-336: Voiding an OpenMRS observation updates observations dataset in Superset #67

merged 3 commits into from
Mar 14, 2024

Conversation

kdaud
Copy link
Contributor

@kdaud kdaud commented Dec 19, 2023 •
edited
Loading

Ticket → OZ-336

Description → This PR adds E2E test asserting that voiding an OpenMRS observation updates observations dataset in Superset

@kdaud kdaud changed the title OZ-336: Voiding OpenMRS data is reflected into Superset Enocounters table through the voided column OZ-336: Voiding O3 data reflected into Superset Enocounters table through voided column Jan 4, 2024
@kdaud kdaud changed the title OZ-336: Voiding O3 data reflected into Superset Enocounters table through voided column OZ-336: Voiding O3 data reflected in Superset Enocounters table through voided column Jan 4, 2024
mks-d
mks-d requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mks-d mks-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you attempt to set a better headline as the PR title? Also there is a small typo, "Enocounters".

@kdaud kdaud changed the title OZ-336: Voiding O3 data reflected in Superset Enocounters table through voided column OZ-336: Voiding O3 data reflected in Superset Encounters table through voided column Jan 22, 2024
@kdaud kdaud changed the title OZ-336: Voiding O3 data reflected in Superset Encounters table through voided column OZ-336: Voiding OpenMRS data reflects in Superset Encounters table within voided column Jan 23, 2024
@kdaud kdaud changed the title OZ-336: Voiding OpenMRS data reflects in Superset Encounters table within voided column OZ-336: Voiding OpenMRS encounter reflects in Superset Encounters table within encounter_voided column Jan 24, 2024
@kdaud kdaud changed the title OZ-336: Voiding OpenMRS encounter reflects in Superset Encounters table within encounter_voided column OZ-336: Voiding an OpenMRS encounter reflects in Superset Encounters table within encounter_voided column Jan 24, 2024
@kdaud kdaud changed the title OZ-336: Voiding an OpenMRS encounter reflects in Superset Encounters table within encounter_voided column OZ-336: Voiding an obs in OpenMRS gets reflected in the observations dataset in Superset Feb 26, 2024
@kdaud kdaud marked this pull request as draft February 26, 2024 11:38
@kdaud kdaud marked this pull request as ready for review February 28, 2024 06:31
@kdaud
Copy link
Contributor Author

kdaud commented Feb 28, 2024

This PR will be ready for review when OZ-483 is resolved.

@kdaud kdaud changed the title OZ-336: Voiding an obs in OpenMRS gets reflected in the observations dataset in Superset OZ-336: Voiding an OpenMRS observation updates observations dataset in Superset Feb 28, 2024
@kdaud kdaud requested a review from Ruhanga February 28, 2024 12:47
@kdaud kdaud requested a review from corneliouzbett March 11, 2024 11:18
Ruhanga
Ruhanga reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good save for one minor concern.

e2e/utils/functions/testBase.ts Outdated Show resolved Hide resolved
@kdaud kdaud requested a review from Ruhanga March 13, 2024 12:20
@kdaud kdaud merged commit e90a8f6 into main Mar 14, 2024
@kdaud kdaud deleted the OZ-336 branch May 27, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mks-d mks-d mks-d requested changes

@Ruhanga Ruhanga Ruhanga approved these changes

@corneliouzbett corneliouzbett Awaiting requested review from corneliouzbett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdaud @mks-d @Ruhanga