Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-523: Setup Ozone E2E versioning #79

Merged
merged 1 commit into from
Apr 12, 2024
Merged

OZ-523: Setup Ozone E2E versioning #79

merged 1 commit into from
Apr 12, 2024

Conversation

kdaud
Copy link
Contributor

@kdaud kdaud commented Apr 11, 2024

Ticket OZ-523

This PR sets the Ozone E2E version being published on NPM Registry.

@kdaud kdaud force-pushed the OZ-523 branch 30 times, most recently from d22daff to 1d5dd16 Compare April 12, 2024 05:28
@kdaud kdaud force-pushed the OZ-523 branch 8 times, most recently from c0c63de to 59db92b Compare April 12, 2024 06:00
@kdaud kdaud requested a review from vasharma05 April 12, 2024 06:18
@vasharma05
Copy link

Are we not using the Ozone version?

@kdaud
Copy link
Contributor Author

kdaud commented Apr 12, 2024

Are we not using the Ozone version?

Sure, we're to use Ozone versioning.

@vasharma05
Copy link

You didn't add the ozVersion in the package.json, nor in the CI job

@kdaud
Copy link
Contributor Author

kdaud commented Apr 12, 2024

You didn't add the ozVersion in the package.json, nor in the CI job

I believe we don't need to include the ozVersion. The Ozone E2E test packages should be linked to the tested Ozone version.

Copy link

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdaud !

@vasharma05 vasharma05 merged commit 7b55c12 into main Apr 12, 2024
Copy link

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdaud please check the push job on the merge of this PR

@kdaud
Copy link
Contributor Author

kdaud commented Apr 12, 2024

@vasharma05 the push job is working as expected.

@kdaud kdaud deleted the OZ-523 branch April 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants