OZ-554: E2E tests for handling voided entities when streaming with Analytics #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaud
force-pushed
the
OZ-554
branch
5 times, most recently
from
dd5bc84 to
f4dd61d
Compare
kdaud
commented
May 20, 2024
| await expect(patientVoidedState).toContainText('false'); | ||
|
|
||
| // replay | ||
| await openmrs.deletePatient(); |
There was a problem hiding this comment.
This particular test case invokes openmrs.deletePatient() during the replay thus voiding the patient. This implies that the test will fail if the method is called again in the cleanup function (afterEach()) so the suggested approach is to let each test case invoke the function that voids the patient.
There was a problem hiding this comment.
If deletions are actually voids in OpenMRS, I'd rather change openmrs.deletePatient() to openmrs.voidPatient().
Ruhanga
reviewed
May 20, 2024
| await expect(patientVoidedState).toContainText('false'); | ||
|
|
||
| // replay | ||
| await openmrs.deletePatient(); |
There was a problem hiding this comment.
If deletions are actually voids in OpenMRS, I'd rather change openmrs.deletePatient() to openmrs.voidPatient().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket OZ-554
This PR adds the following E2E tests handling voidable entities when streaming with Analytics.