-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maven-parent: Copy locally defined OMODs #46
Conversation
cc: @rbuisson @Ruhanga @corneliouzbett I'd appreciate your reviews on this. |
@ibacher , @corneliouzbett had done this in order to account for the issue of not copying non-omod dependencies. In that instance, excluding the Camel routes. Doesn't it suffice? Or do you anticipate possible other non-omods deps that should be removed? |
I think it suffices for Ozone itself—and is actually a better solution than what I've implemented here. I was sort of anticipating "what happens if an Ozone FOSS user implements their own eip", but maybe that's not something we need to anticipate? |
Well, fair enough. We might as well go for a solution that's generic enough. cc @corneliouzbett . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense @ibacher. This means the change done earlier goes away? @corneliouzbett?
@Ruhanga I guess so, but it's harmless since I added a delete step to delete those files anyways. |
@ibacher could you take a look at those conflicts? Then we can merge. |
I was just working on resolving them. I think we should be good. |
The main goal of this PR is to enable copying any OMOD dependencies into to the OpenMRS modules directory. This is done using the same pattern as Ozone. I've also update the distribution itself to delete any non-OMOD JARs that are accidentally included by deleting them.