OZ-468: Do not substitute the Maven Parent snapshot version in archetype resources #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuisson
force-pushed
the
do-not-set-parent-version
branch
from
fb77ee0 to
493b986
Compare
ibacher
suggested changes
Mar 27, 2024
Comment on lines
-91
to
-94
| if (!isWindows) { | ||
| run("chmod +x ${projectDirectory.resolve("scripts").resolve("mvnw").toString()}") | ||
| run("chmod +x ${projectDirectory.resolve("scripts").resolve("mvnwDebug").toString()}") | ||
| } |
There was a problem hiding this comment.
This should still be left in! Otherwise mvnw won't end up as a executable.
|
Running this locally, the test version altogether lacks the part like this: Instead having three blank lines at the end. Not sure why that is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, this does not build.
Which I don't understand. The README files appear to be equal... @ibacher , any idea?