KH-539: Add default Superset datasets #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruhanga
reviewed
Jun 13, 2024
| offset: 0 | ||
| cache_timeout: null | ||
| schema: public | ||
| sql: 'SELECT * FROM concepts ' |
There was a problem hiding this comment.
Thanks for the PR @enyachoke, do we however need to consume these datasets, or these are somewhat place holders/example dataset configs (apart from the database config)?
There was a problem hiding this comment.
We don't have to, but if we have any datasets which could conflict, we need to make sure we sync them up.
There was a problem hiding this comment.
Remove the trailing space in the SELECT * FROM concepts
@Ruhanga , yes, those are the default ones that will come with Ozone anyway.
rbuisson
requested changes
Jun 14, 2024
| @@ -0,0 +1,16 @@ | |||
| database_name: PostgreSQL | |||
There was a problem hiding this comment.
@enyachoke this database should probably be named "Analytics", isn't it?
and should we update the file name to reflect that as well?
enyachoke
force-pushed
the
KH-539-datasets
branch
from
6d136d8 to
8529105
Compare
rbuisson
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to initial work on https://mekomsolutions.atlassian.net/browse/KH-539, we needed to bring in some default datasets and database connection.