fix bug with incorrect time duration of tests #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilKhaybulin
approved these changes
Sep 21, 2023
koodeex
reviewed
Sep 22, 2023
|
|
||
| // getTimeSumOfSteps gets first step start time and last step end time | ||
| func getTimeSumOfSteps(result *Result) (startTimeInt int64, endTimeInt int64) { | ||
| startTime := result.Steps[0].Start |
There was a problem hiding this comment.
there will be panic if Steps array is empty
There was a problem hiding this comment.
although, how are you going work with following case?
func TestSome(t provider.T) {
time.Sleep(3 * time.Second)
t.WithNewStep(...)
}| func (result *Result) Print() error { | ||
| overWriteStartAndEndTime(result) |
There was a problem hiding this comment.
if len(result.Steps) > 0 {
overWriteStartAndEndTime(result)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #41