Fix C++ Modules support in xmake.lua #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current argparse provides an
xmake.lua, but for unknown reasons, it is not used by the argparse remote package in xmake-repo, and that remote package doesn't provide C++ Modules support. I tried creating a local package that could utilize argparse's existingxmake.lua, and discovered that the existingxmake.luain argparse had some bugs regarding C++ Modules support. These bugs didn't manifest during local testing, but appeared when the package was built. This PR fixes that bug, enabling the proper use of C++ Modules when pulling the argparse package externally. After this PR is merged, I will fix the argparse package in xmake-repo to utilize thexmake.luaprovided by argparse itself and provide C++ Modules support.