Name: turn into string alias #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2657-d838b9d84605
…5112657-d838b9d84605
…gicalcluster.Path
p0lyn0mial
reviewed
Dec 6, 2022
| @@ -50,7 +50,7 @@ type customResourceDefinitionsClusterClient struct { | |||
|
|
|||
| // Cluster scopes the client down to a particular cluster. | |||
| func (c *customResourceDefinitionsClusterClient) Cluster(cluster logicalcluster.Path) apiextensionsv1beta1client.CustomResourceDefinitionInterface { | |||
| if cluster == logicalcluster.WildcardPath { | |||
There was a problem hiding this comment.
no, this code was autogenerated :)
p0lyn0mial
reviewed
Dec 6, 2022
| @@ -86,10 +86,10 @@ func ValidClusterFrom(ctx context.Context) (*Cluster, error) { | |||
| func ClusterNameFrom(ctx context.Context) (logicalcluster.Name, error) { | |||
| cluster, err := ValidClusterFrom(ctx) | |||
| if err != nil { | |||
| return logicalcluster.Name{}, err | |||
There was a problem hiding this comment.
Line 89 and 92 are the only valid changes in this PR, right?
p0lyn0mial
force-pushed
the
kcp-feature-logical-clusters-1.24-v3
branch
5 times, most recently
from
614c602 to
0669e76
Compare
p0lyn0mial
force-pushed
the
kcp-feature-logical-clusters-1.24-v3
branch
from
0669e76 to
abcb3d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.