Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fewer messages than nonces #32

Open
wants to merge 3 commits into
base: feature/multiple-nonces
Choose a base branch
from

Conversation

matthewjablack
Copy link

@matthewjablack matthewjablack commented Feb 4, 2021

Since DLC CET compression involves outputs requiring fewer nonces, this PR enables fewer messages than nonces to be passed into CreateCetAdaptorSignature and VerifyCetAdaptorSignature, which calculates the adaptor point based nonces up to the length of msgs array.

Numeric Outcome Details

@matthewjablack matthewjablack changed the title Add ability to pass in fewer messages than nonces Enable fewer messages than nonces Feb 4, 2021
@Tibo-lg Tibo-lg force-pushed the feature/multiple-nonces branch 2 times, most recently from 649af4e to c872272 Compare February 4, 2021 06:27
@matthewjablack matthewjablack force-pushed the feature/multiple-nonces-msgs-based branch from a6b8808 to e6d7a4b Compare February 4, 2021 07:19
@Tibo-lg
Copy link
Collaborator

Tibo-lg commented Feb 4, 2021

Can you just rebase on develop and squash your commits? Also reviewing your code I noticed that there is a check lacking in ComputeAdaptorPoint, I think if you pass an empty vector of r_values it will crash, so it'd be nice to add a condition to the check at the beginning of the function. I can also add it later though, just if you're motivated :)

Also really nit-picking but if you could separate the change to the .gitignore in a separate commit it'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants