Remove global context use from dlc-manager #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is more tricky than I thought, need some time to fix it properly. |
Tibo-lg
force-pushed
the
fix/remove-global-context
branch
from
bf7fa12 to
501722d
Compare
|
Should be good like that. Note that the compilation only fails after updating the dependencies (#197), really unsure why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #188 broke the build of
dlc-manager(when building from the folder, not the workspace) because of using the secp global-context while not importing it as a feature. As I'm not super keen on adding extra features I removed the need for it with some refactoring.@benthecarman can you have a look and make sure it still works for you?