Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OracleEvent.validate() for signed numeric events #243

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix OracleEvent.validate() for signed numeric events #243

merged 2 commits into from
Nov 6, 2024

Conversation

rorp
Copy link
Contributor

@rorp rorp commented Oct 31, 2024

For some reason OracleEvent.validate() doesn't count a nonce for the sign. This PR fixes this.

@rorp rorp mentioned this pull request Oct 31, 2024
Open
Tibo-lg
Tibo-lg reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you think that you could add a test that fails without the change and passes with it?

@rorp rorp requested a review from Tibo-lg November 4, 2024 20:50
Tibo-lg
Tibo-lg approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bennyhodl
Copy link
Contributor

Is this going to merge and release?

bennyhodl/kormir#14

@Tibo-lg Tibo-lg merged commit 39825dd into p2pderivatives:master Nov 6, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tibo-lg Tibo-lg Tibo-lg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rorp @bennyhodl @Tibo-lg