Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel keys to channel details #8

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Channel keys to channel details #8

merged 1 commit into from
Sep 6, 2023

Conversation

Tibo-lg
Copy link

@Tibo-lg Tibo-lg commented Aug 15, 2023

  • Add channel keys to channel details to be able to generate signers outside of LDK
  • Remove the sign_with_callback function from ChannelManager

@Tibo-lg Tibo-lg changed the base branch from main to split-tx-experiment August 15, 2023 01:40
@Tibo-lg Tibo-lg requested a review from luckysori August 16, 2023 00:59
@luckysori
Copy link
Collaborator

Should we merge this one, @Tibo-lg?

@Tibo-lg
Copy link
Author

Tibo-lg commented Sep 6, 2023

Sure will do

@Tibo-lg Tibo-lg merged commit c4505a3 into split-tx-experiment Sep 6, 2023
4 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckysori luckysori luckysori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tibo-lg @luckysori