Increase PING_TIMER to 20 seconds
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value was chosen sort of arbitrarily acccording to 2d3a210. By doubling this timeout we hope to keep the connection alive when performing the very heavy and chatty DLC-related protocols.
Tibo-lg
approved these changes
Aug 31, 2023
It's not something that occurs in tests, but we've definitely seen connection drops during subchannel setup and closure in production. Tbh, I would like to revert this at some point, but we are keen to test it out for now. I'll go ahead with the merge since you gave approval, but it's also okay to keep this setting just for 10101 if it bothers you in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value was chosen sort of arbitrarily according to 2d3a210.
By doubling this timeout we hope to keep the connection alive when performing the very heavy and chatty DLC-related protocols.
What do you think, @Tibo-lg? We've been running into a lot of problems because of this ping timeout and it's made me wonder if this number is not high enough for the kinds of protocols that we run with the split channel.