[P4Testgen] Replace absl::btree_map with the P4::flat_map implementation #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fruffy I think we can jus grab existing |
|
Added few tests and did some fixes here and there |
fruffy
force-pushed
the
fruffy/flat_map
branch
3 times, most recently
from
2067229
to
7ba600c
Compare
fruffy
force-pushed
the
fruffy/flat_map
branch
4 times, most recently
from
4099d76
to
9bc74fc
Compare
fruffy
force-pushed
the
fruffy/flat_map
branch
from
9bc74fc
to
981f59d
Compare
…ion in P4Tools. Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/flat_map
branch
from
981f59d
to
b8eb277
Compare
fruffy
changed the title
fruffy
changed the title
fruffy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flat map implementation was donated by @asl. It seems a little faster than btree_map.