Crude port of Tofino dynamic hash to C++ #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Korobeynikov <[email protected]>
|
Spin-off from #5033 |
fruffy
approved these changes
Dec 2, 2024
fruffy
reviewed
Dec 2, 2024
| @@ -970,7 +970,7 @@ target_include_directories( | |||
| # FIXME: This should be pulled with FetchContent. | |||
| PRIVATE "${BFN_P4C_SOURCE_DIR}/third_party/spdlog/include" | |||
| ) | |||
| add_dependencies(tofinobackend ir-generated frontend genLogging bfn_p4runtime) | |||
| add_dependencies(tofinobackend frontend genLogging bfn_p4runtime) | |||
There was a problem hiding this comment.
Assume this is remove because of the frontend dependency?
There was a problem hiding this comment.
Yes. Actually, the majority add_dependencies are not needed at all. This seems to be an old hack used to "close" some absence of proper dependencies. This needs to be eventually removed from everywhere and replaced with proper deps (e.g. target_link_libraries, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.