Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to backends/tc/CMakeLists.txt updated version release-v17-rc8 and sha256 hash #5173

Closed
wants to merge 0 commits into from

Conversation

trvon
Copy link

@trvon trvon commented Mar 10, 2025

Updating release version and sha256 of iproute2repo to fix dead URL issue in build. issue

@trvon trvon changed the title Update CMakeLists.txt Update to backends/tc/CMakeLists.txt updated version release-v17-rc8 and sha256 hash Mar 10, 2025
@jafingerhut
Copy link
Contributor

@trvon Thanks for the PR. If you could take a look at this alternate PR to verify whether it includes all of your changes (and more), that would be appreciated: #5172

@trvon
Copy link
Author

trvon commented Mar 10, 2025

I will verify my approach against the current test cases, but it looks like the other pull request takes a different approach by moving the iproute2repo and p4cbpfrepo fetch and build from the backends/tc/CMakeList.txt to tools/ci-build.sh.

@jafingerhut
Copy link
Contributor

I will verify my approach against the current test cases, but it looks like the other pull request takes a different approach by moving the iproute2repo and p4cbpfrepo fetch and build from the backends/tc/CMakeList.txt to tools/ci-build.sh.

My guess/belief is that without that other PR's changes, or something like them, iproute2 is built for all of the current CI tests, which is unnecessary given that it is only used for tests on the p4tc backend.

@trvon
Copy link
Author

trvon commented Mar 10, 2025

I see that the merge of the other branch went through, I can close this request if needed. I was also able to fix the test errors with another hash update to the requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants