Quart2 #53
Open
Quart2 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lbum, get items and the artwork endpoint.
beets now has some more Types, removed ours interactive session still needs work
library route. Added some test data to use with beets (mp3 and cover art).
our with_loop function did not get all (but some ?!) emits out. using asyncio.run() with nested_async applied seems to work better. remaining issues: - session closing / pipeline running does not work. could be the session_ref in the importer route (now a asyncio.task, before probably a threading.process?) - not sure if we need to put pipeline.run_ into its own async loop, as i have done now. - frontend: status display does not get set reliably
better organized. To keep all routing and quart related code in one folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the migration from flask to quart.
We should decide if we want to do the refactor of default import / previews also in this branch.