-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectrum refactoring, Spectrum2DCollection #305
Commits on Sep 18, 2024
-
Create a Mixin for some Spectrum1DCollection methods, rewrite select()
- This version of select() should be more robust in dealing with parameters that exist in "top level" of metadata dict - I hope it is also easier to understand
Configuration menu - View commit details
-
Copy full SHA for 136fca5 - Browse repository at this point
Copy the full SHA 136fca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e825e69 - Browse repository at this point
Copy the full SHA e825e69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 067339a - Browse repository at this point
Copy the full SHA 067339aView commit details -
Update Spectrum methods to use Quantity rather than *ureg.
Some of this was done in another branch, and this one rebased
Configuration menu - View commit details
-
Copy full SHA for 28a5b1e - Browse repository at this point
Copy the full SHA 28a5b1eView commit details -
Pylint doesn't like the call to ._set_spectrum_data on another class instance because it doesn't understand that this instance was just created with the current class. I think that means the warning is ok to suppress.
Configuration menu - View commit details
-
Copy full SHA for a47778f - Browse repository at this point
Copy the full SHA a47778fView commit details -
Reimplement spectrum group_by with toolz, FP style
This adds toolz as a dependency to the main package. We don't anticipate that causing a lot of problems; it is a small, stable, pure-python library also available on conda-forge.
Configuration menu - View commit details
-
Copy full SHA for f98c053 - Browse repository at this point
Copy the full SHA f98c053View commit details -
Linters hate the named lambdas. I think they are quite nice because they are compact and immediately draw attention to the "one-liner" they attach a name to... but maybe the more explicit form with type hints will make it easier for someone to understand in future.
Configuration menu - View commit details
-
Copy full SHA for 5b29747 - Browse repository at this point
Copy the full SHA 5b29747View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1159b5c - Browse repository at this point
Copy the full SHA 1159b5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4b4626 - Browse repository at this point
Copy the full SHA e4b4626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01469f8 - Browse repository at this point
Copy the full SHA 01469f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44ed62b - Browse repository at this point
Copy the full SHA 44ed62bView commit details -
Refactor __getitem__ and move into SpectrumCollectionMixin
This structure seems a bit more legible and should reduce redundancy in Spectrum2DCollection
Configuration menu - View commit details
-
Copy full SHA for a7ce9db - Browse repository at this point
Copy the full SHA a7ce9dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e05e0e - Browse repository at this point
Copy the full SHA 0e05e0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79ff127 - Browse repository at this point
Copy the full SHA 79ff127View commit details -
Configuration menu - View commit details
-
Copy full SHA for a041d72 - Browse repository at this point
Copy the full SHA a041d72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35544a1 - Browse repository at this point
Copy the full SHA 35544a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c445fb9 - Browse repository at this point
Copy the full SHA c445fb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9bff3d - Browse repository at this point
Copy the full SHA e9bff3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae3648b - Browse repository at this point
Copy the full SHA ae3648bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4659cad - Browse repository at this point
Copy the full SHA 4659cadView commit details -
Refactor spectrum item data access to methods
Collect the axis-twiddling code in one place to improve readability.
Configuration menu - View commit details
-
Copy full SHA for e32aa45 - Browse repository at this point
Copy the full SHA e32aa45View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb87b7d - Browse repository at this point
Copy the full SHA fb87b7dView commit details -
Spectrum2DCollection; more testing, fix sum()
- Refactor re-used data import to use pytest fixture - Remove initial from_spectra test; new one covers it all - Test from_spectra with inconsistent input - Test mixin-supplied methods
Configuration menu - View commit details
-
Copy full SHA for 6235aab - Browse repository at this point
Copy the full SHA 6235aabView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5c9756 - Browse repository at this point
Copy the full SHA e5c9756View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56dfcb9 - Browse repository at this point
Copy the full SHA 56dfcb9View commit details
Commits on Sep 19, 2024
-
Apply suggestions from code review
Make things a little cleaner and more idiomatic Co-authored-by: Jacob Wilkins <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ade79e1 - Browse repository at this point
Copy the full SHA ade79e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ecad2c - Browse repository at this point
Copy the full SHA 3ecad2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8631bc4 - Browse repository at this point
Copy the full SHA 8631bc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb808ba - Browse repository at this point
Copy the full SHA eb808baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19f36ab - Browse repository at this point
Copy the full SHA 19f36abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dda596 - Browse repository at this point
Copy the full SHA 5dda596View commit details -
Configuration menu - View commit details
-
Copy full SHA for b647cb7 - Browse repository at this point
Copy the full SHA b647cb7View commit details
Commits on Sep 20, 2024
-
- This avoids some of the repetition in dict comprehensions to remove an element - Here we also slightly rework _combine_metadata so it is clearer what each variable represents.
Configuration menu - View commit details
-
Copy full SHA for aaaa25a - Browse repository at this point
Copy the full SHA aaaa25aView commit details -
list comprehension is little clunky but avoids the 1-length special case: cleaner overall
Configuration menu - View commit details
-
Copy full SHA for 87f32a0 - Browse repository at this point
Copy the full SHA 87f32a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b682432 - Browse repository at this point
Copy the full SHA b682432View commit details
Commits on Sep 26, 2024
-
Via discussion / pair-programming with @oerc0122 - Use native dict comprehension over keyfilter in iter_metadata: it's a bit ugly but no more complicated, and should be easier to read "casually" - Clearer comment re: value-pair combination - Replace a lambda with named partial function and toolz complement
Configuration menu - View commit details
-
Copy full SHA for 0f7ec81 - Browse repository at this point
Copy the full SHA 0f7ec81View commit details -
Remove redundant .keys() when iterating over dict
Co-authored-by: Jacob Wilkins <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef314a0 - Browse repository at this point
Copy the full SHA ef314a0View commit details