Skip to content

Increase extensibility of BasicGraphicsScene and GraphicsView #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Increase extensibility of BasicGraphicsScene and GraphicsView #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac0500
Make GraphicView on* methods virtual
nolankramer Sep 17, 2025
b7c4761
Increase extensibility
nolankramer Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions include/QtNodes/internal/BasicGraphicsScene.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ class NODE_EDITOR_PUBLIC BasicGraphicsScene : public QGraphicsScene

void setConnectionPainter(std::unique_ptr<AbstractConnectionPainter> newPainter);

void setNodeGeometry(std::unique_ptr<AbstractNodeGeometry> newGeom);

QUndoStack &undoStack();

public:
Expand Down Expand Up @@ -139,17 +141,17 @@ class NODE_EDITOR_PUBLIC BasicGraphicsScene : public QGraphicsScene

public Q_SLOTS:
/// Slot called when the `connectionId` is erased form the AbstractGraphModel.
void onConnectionDeleted(ConnectionId const connectionId);
virtual void onConnectionDeleted(ConnectionId const connectionId);

/// Slot called when the `connectionId` is created in the AbstractGraphModel.
void onConnectionCreated(ConnectionId const connectionId);

void onNodeDeleted(NodeId const nodeId);
void onNodeCreated(NodeId const nodeId);
void onNodePositionUpdated(NodeId const nodeId);
void onNodeUpdated(NodeId const nodeId);
void onNodeClicked(NodeId const nodeId);
void onModelReset();
virtual void onConnectionCreated(ConnectionId const connectionId);

virtual void onNodeDeleted(NodeId const nodeId);
virtual void onNodeCreated(NodeId const nodeId);
virtual void onNodePositionUpdated(NodeId const nodeId);
virtual void onNodeUpdated(NodeId const nodeId);
virtual void onNodeClicked(NodeId const nodeId);
virtual void onModelReset();

private:
AbstractGraphModel &_graphModel;
Expand Down
8 changes: 4 additions & 4 deletions include/QtNodes/internal/GraphicsView.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ public Q_SLOTS:

void setupScale(double scale);

void onDeleteSelectedObjects();
virtual void onDeleteSelectedObjects();

void onDuplicateSelectedObjects();
virtual void onDuplicateSelectedObjects();

void onCopySelectedObjects();
virtual void onCopySelectedObjects();

void onPasteObjects();
virtual void onPasteObjects();

Q_SIGNALS:
void scaleChanged(double scale);
Expand Down
5 changes: 5 additions & 0 deletions src/BasicGraphicsScene.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ void BasicGraphicsScene::setConnectionPainter(std::unique_ptr<AbstractConnection
_connectionPainter = std::move(newPainter);
}

void BasicGraphicsScene::setNodeGeometry(std::unique_ptr<AbstractNodeGeometry> newGeom)
{
_nodeGeometry = std::move(newGeom);
}

QUndoStack &BasicGraphicsScene::undoStack()
{
return *_undoStack;
Expand Down
Loading