pass matrix by reference in kendall_cor

pachadotdev · Jul 4, 2024 · fec825f · fec825f
1 parent 82819f9
commit fec825f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -59,6 +59,7 @@ importFrom(rlang,":=")
 importFrom(rlang,sym)
 importFrom(stats,as.formula)
 importFrom(stats,binomial)
+importFrom(stats,complete.cases)
 importFrom(stats,gaussian)
 importFrom(stats,model.matrix)
 importFrom(stats,na.omit)

diff --git a/R/capybara-package.R b/R/capybara-package.R
@@ -12,12 +12,14 @@
 #' and Wanner (2020).
 #'
 #' @name capybara-package
-#' @importFrom dplyr across all_of filter group_by mutate pull select summarise ungroup vars
+#' @importFrom dplyr across all_of filter group_by mutate pull select summarise
+#'  ungroup vars
 #' @importFrom Formula Formula
 #' @importFrom MASS negative.binomial theta.ml
 #' @importFrom rlang sym :=
 #' @importFrom stats as.formula binomial model.matrix na.omit gaussian poisson
 #'  pnorm printCoefmat rgamma rlogis rnorm rpois terms vcov predict
+#'  complete.cases
 #' @importFrom utils combn
 #' @useDynLib capybara, .registration = TRUE
 "_PACKAGE"

diff --git a/src/05_kendall_correlation.cpp b/src/05_kendall_correlation.cpp
@@ -88,7 +88,7 @@ uint64_t merge_sort_(double *x, double *buf, size_t len) {
   return swaps;
 }
 
-[[cpp11::register]] double kendall_cor_(doubles_matrix<> m) {
+[[cpp11::register]] double kendall_cor_(const doubles_matrix<> &m) {
   size_t len = m.nrow();
   std::vector<double> arr1(len), arr2(len);
   std::vector<double> buf(len);

diff --git a/src/cpp11.cpp b/src/cpp11.cpp
@@ -139,10 +139,10 @@ extern "C" SEXP _capybara_sqrt_(SEXP w) {
   END_CPP11
 }
 // 05_kendall_correlation.cpp
-double kendall_cor_(doubles_matrix<> m);
+double kendall_cor_(const doubles_matrix<> & m);
 extern "C" SEXP _capybara_kendall_cor_(SEXP m) {
   BEGIN_CPP11
-    return cpp11::as_sexp(kendall_cor_(cpp11::as_cpp<cpp11::decay_t<doubles_matrix<>>>(m)));
+    return cpp11::as_sexp(kendall_cor_(cpp11::as_cpp<cpp11::decay_t<const doubles_matrix<> &>>(m)));
   END_CPP11
 }