Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default_parse_time_macros for packit-service #595

Merged

Conversation

lbarcziova
Copy link
Member

Follow up of packit/packit#2408

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d3ca8792b6b04d0d95052f612bf32a5d

✔️ pre-commit SUCCESS in 1m 37s
deployment-tests NODE_FAILURE Node request 200-0007575824 failed in 0s

@lbarcziova lbarcziova self-assigned this Sep 15, 2024
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Contributor

@majamassarini
Copy link
Member

majamassarini commented Sep 17, 2024

Regarding the failing test, I forgot that you can't access the keys stored in github unless you are working from the packit repo itself (not from a fork).
I am not sure if there exist a safe way to workaround this restriction.
There exist the pull_request_target trigger which we could use since the action is now in the main branch, but reading the docs:

In order to solve this, we’ve added a new pull_request_target event, which behaves in an almost identical way to the pull_request event with the same set of filters and payload. However, instead of running against the workflow and code from the merge commit, the event runs against the workflow and code from the base of the pull request.

I don't think it is meant for solving the problem of testing new code.

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Sep 18, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/47e860161364453287ee31375e42857c

✔️ pre-commit SUCCESS in 1m 44s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aaf4d30 into packit:main Sep 18, 2024
3 of 4 checks passed
@lbarcziova lbarcziova deleted the macros-packit-service branch September 18, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants