Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/valkey support #597

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Feat/valkey support #597

merged 5 commits into from
Oct 9, 2024

Commits on Oct 8, 2024

  1. feat: make key-value DB deployment generic

    1. Rely on a single tag ‹with_kv_database› for deciding whether it
       should be deployed or not.
    2. Introduce a new variable ‹kv_database› that holds the name of the KV
       database that might be deployed.
       - Also allows for easier deduction of the hostname and makes sure
         that there's always at least one deployment of any kind, i.e., it
         is now not possible to require it present, but have incorrect
         combination of flags, e.g., neither ‹with_redis› nor ‹with_redict›
         set.
    3. Add it to templates where it's been forgotten.
    
    Signed-off-by: Matej Focko <[email protected]>
    mfocko committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4fefa37 View commit details
    Browse the repository at this point in the history
  2. feat: add OpenShift definition for Valkey

    Signed-off-by: Matej Focko <[email protected]>
    mfocko committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cb0e203 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1596ca4 View commit details
    Browse the repository at this point in the history
  4. feat(kv-db): add default config for redis-like DBs

    The leaks in short-running pods result in idle connections
    to Redict/Valkey, all of these KV-databases have ‹timeout› option in
    their config that allows for iterative cleanup of hanging connections.
    
    This mitigates the issue to the point of still having free connections
    slots to Redict/Valkey, i.e., the pods shall be killed, but handlers do
    not end up in a retry-loop trying to connect to Redict/Valkey.
    
    Since the config is 1:1 between all Redis, Redict, and Valkey, create
    one ConfigMap, map the config into the databases and pass the path
    to the config as an argument.
    
    Tested with Redict and Valkey. »NOT« tested with Redis.
    
    Related to packit/packit-service#2522
    
    Signed-off-by: Matej Focko <[email protected]>
    mfocko committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    64cdcec View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. fix(valkey): implement remarks from code review

    - Remove tags for redis and redict, they would not be very helpful,
      since the specific implementation of KV-DB is taken from the variables
      anyways
    - Add missing Valkey to the deploymentconfigs
    - Add comment with options to the deployment templates
    
    Co-authored-by: Maja Massarini <[email protected]>
    Signed-off-by: Matej Focko <[email protected]>
    mfocko and majamassarini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    660a23a View commit details
    Browse the repository at this point in the history