-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the compile()
statement from regexp_match()
#2606
Conversation
Signed-off-by: Nikola Forró <[email protected]>
Build succeeded. ✔️ pre-commit SUCCESS in 2m 31s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be hard to add a testcase for this? (in a followup PR would be ok as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test it in tests_openshift/database
? Or are we confident enough?
I'm not sure, how would you go about testing this? |
I thought we disabled those.
We are not 😅 |
yes, but I am still running them locally. They are good for catching this kind of bugs. And you need just the postgres container running... but I can run them. |
Signed-off-by: Nikola Forró <[email protected]>
I've added some tests and they pass locally, so it seems the fix works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Build succeeded. ✔️ pre-commit SUCCESS in 2m 21s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 9m 38s |
82b48f8
into
packit:main
Related to #2596.
Fixes #2605.