fix(jobs): force ‹__str__› when logging jobs #2726
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, even if there is a ‹__str__› implementation, logging still uses ‹__repr__› which prints everything in a sort-of JSON format. Therefore map each of the jobs to their respective string representation during the logging to force the usage of the ‹__str__› instead of the ‹__repr__›. Related to packit/packit#2306 Signed-off-by: Matej Focko <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 54s |
nforro
approved these changes
Feb 19, 2025
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 56s |
softwarefactory-project-zuul
bot
merged commit cc1dba0
into
packit:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, even if there is a ‹str› implementation, logging still uses ‹repr› which prints everything in a sort-of JSON format.
Therefore map each of the jobs to their respective string representation during the logging to force the usage of the ‹str› instead of the ‹repr›.
Related to packit/packit#2306