Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue on failed propose update #300

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Issue on failed propose update #300

merged 3 commits into from
Dec 13, 2019

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Dec 12, 2019 •
edited
Loading

  • Create a new issue if the propose-update fail.
  • Name of the issue: [packit] Propose update failed for release {self.event.tag_name}
  • Mock of the description:

Screenshot from 2019-12-12 13-26-14

Screenshot from 2019-12-13 15-07-37

@lachmanfrantisek lachmanfrantisek force-pushed the issue-on-failed-propose-update branch 2 times, most recently from 3f4bf53 to 97223f9 Compare December 12, 2019 12:16
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

TomasTomecek
TomasTomecek reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include a test case

@TomasTomecek
Copy link
Member

the output looks rocking though!

@lachmanfrantisek lachmanfrantisek force-pushed the issue-on-failed-propose-update branch from 6f5adeb to 66c541e Compare December 13, 2019 10:46
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@lachmanfrantisek
Copy link
Member Author

please include a test case

Done -- I am not done with the requre tests for update in packit so I've used the flexmock.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jpopelka jpopelka added the mergeit When set, zuul wil gate and merge the PR. label Dec 13, 2019
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ad76a22 into packit:master Dec 13, 2019
@lachmanfrantisek lachmanfrantisek deleted the issue-on-failed-propose-update branch December 13, 2019 12:37
@lachmanfrantisek lachmanfrantisek mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek left review comments

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lachmanfrantisek @TomasTomecek @jpopelka