Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multi-line tag values #412

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

nforro
Copy link
Member

@nforro nforro commented Sep 26, 2024

Fixes #410.

RELEASE NOTES BEGIN

specfile can now handle multi-line tag values (enclosed in a macro body, e.g. %shrink).

RELEASE NOTES END

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ae434c08232b47c59efaa645b3956cc8

✔️ pre-commit SUCCESS in 2m 18s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 18s
✔️ specfile-tests-pip-deps SUCCESS in 1m 09s

specfile/tags.py Outdated Show resolved Hide resolved
Signed-off-by: Nikola Forró <[email protected]>
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/7b34ff761a104904a53cf8cf2fbd4e18

✔️ pre-commit SUCCESS in 2m 46s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 13s
✔️ specfile-tests-pip-deps SUCCESS in 1m 12s

@nforro nforro added the mergeit Zuul, merge it! label Sep 26, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9181e5538fe7448098c684e64b61f90f

✔️ pre-commit SUCCESS in 2m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 89cd1a4 into main Sep 26, 2024
34 checks passed
@nforro nforro deleted the multiline-tags branch September 26, 2024 13:54
softwarefactory-project-zuul bot added a commit to packit/packit.dev that referenced this pull request Sep 30, 2024
Add blog post for week 39

I've skipped packit/specfile#412 if you don't mind...

Reviewed-by: Nikola Forró
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot parse %shrink
2 participants