Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building specfile in CentOS Stream without EPEL #423

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Allow building specfile in CentOS Stream without EPEL #423

merged 1 commit into from
Nov 12, 2024

Conversation

majamassarini
Copy link
Member

@majamassarini majamassarini commented Nov 12, 2024 •
edited
Loading

CentOS Stream does not have EPEL packages in CBS Koji.
Package typing-extensions is not available.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6683b7b2dce14f288b5701c695252f77

✔️ pre-commit SUCCESS in 2m 08s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 10s
✔️ specfile-tests-pip-deps SUCCESS in 1m 08s

nforro
nforro approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Just a nitpick about the commit message. I would change it to Allow building specfile in CentOS Stream without EPEL. We regularly build specfile in CentOS Stream, just with EPEL repos enabled.

nforro
nforro reviewed Nov 12, 2024
View reviewed changes
specfile/types.py Outdated Show resolved Hide resolved
@majamassarini majamassarini changed the title Allow building specfile in CentOS Stream Allow building specfile in CentOS Stream without EPEL Nov 12, 2024
@majamassarini @nforro
Allow building specfile in CentOS Stream without EPEL
04839bb 
When building CentOS Stream in CBS Koji,
EPEL packages are not available.
There is no package typing-extensions.

Co-authored-by: Nikola Forró <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5a2ba077dbfc472fa42e740b4f8460f0

✔️ pre-commit SUCCESS in 2m 15s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 19s
✔️ specfile-tests-pip-deps SUCCESS in 1m 21s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d093118df83241038d47fd699cb6a29e

✔️ pre-commit SUCCESS in 2m 15s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 15s
✔️ specfile-tests-pip-deps SUCCESS in 1m 15s

@majamassarini majamassarini added the mergeit Zuul, merge it! label Nov 12, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2d25549638fc491ab5ba3061291f1c50

✔️ pre-commit SUCCESS in 2m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7e887f0 into packit:main Nov 12, 2024
4 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nforro nforro nforro approved these changes

Assignees
No one assigned
Labels
mergeit Zuul, merge it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majamassarini @nforro