Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring addon naming in line with Docker mods and themepark docs #19

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

saltydk
Copy link
Contributor

@saltydk saltydk commented Mar 17, 2024

This should change the current output of:

<link rel="stylesheet" type="text/css" href="https://theme-park.dev/css/addons/readarr/readarr-readarr-alt-logo/readarr-readarr-alt-logo.css">

to the correct (when following themepark docs):

<link rel="stylesheet" type="text/css" href="https://theme-park.dev/css/addons/readarr/readarr-alt-logo/readarr-alt-logo.css">

Not super familiar with Traefik plugin development so please do your own test of this.

The PR was made because your own documentation does not line up with the themepark docs: https://docs.theme-park.dev/themes/addons/sonarr/sonarr-4k-logo/#traefik
Which specify it like this:

middlewares:
    sonarr-4k-logo:
        plugin:
            themepark:
                app: sonarr
                theme: base
                addons:
                    - sonarr-4k-logo

This would align both sides with how the Docker mod addons are specified. Feel free to close this if docs get updated instead, have notified the developer.

@saltydk saltydk changed the title Fix addon url Bring addon naming in line with Docker mods and themepark docs Mar 17, 2024
@packruler
Copy link
Owner

@saltydk thanks for making this PR!
I added ongoing support for how addons worked prior to this update and added a quick test for the new system.

@packruler packruler enabled auto-merge (squash) March 29, 2024 20:04
@packruler
Copy link
Owner

fixes #15

@packruler packruler merged commit 094cba5 into packruler:main Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants