chore: Don't validate example value with regex

pact-foundation · Dec 2, 2024 · 58bea54 · 58bea54
1 parent 251f566
commit 58bea54
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 42 deletions.
diff --git a/src/PhpPact/Consumer/Matcher/Exception/InvalidRegexException.php b/src/PhpPact/Consumer/Matcher/Exception/InvalidRegexException.php
diff --git a/src/PhpPact/Consumer/Matcher/Matchers/Regex.php b/src/PhpPact/Consumer/Matcher/Matchers/Regex.php
@@ -3,17 +3,13 @@
 namespace PhpPact\Consumer\Matcher\Matchers;
 
 use PhpPact\Consumer\Matcher\Exception\InvalidValueException;
-use PhpPact\Consumer\Matcher\Exception\InvalidRegexException;
 use PhpPact\Consumer\Matcher\Generators\Regex as RegexGenerator;
 use PhpPact\Consumer\Matcher\Model\Attributes;
 use PhpPact\Consumer\Matcher\Model\Expression;
 use PhpPact\Consumer\Matcher\Model\Matcher\ExpressionFormattableInterface;
 use PhpPact\Consumer\Matcher\Model\Matcher\JsonFormattableInterface;
 use PhpPact\Consumer\Matcher\Trait\JsonFormattableTrait;
 
-use function preg_last_error;
-use function preg_match;
-
 class Regex extends GeneratorAwareMatcher implements JsonFormattableInterface, ExpressionFormattableInterface
 {
     use JsonFormattableTrait;
@@ -27,28 +23,10 @@ public function __construct(
     ) {
         if ($values === null) {
             $this->setGenerator(new RegexGenerator($this->regex));
-        } else {
-            $this->validateRegex();
         }
         parent::__construct();
     }
 
-    /**
-     * @todo Use json_validate()
-     */
-    private function validateRegex(): void
-    {
-        foreach ((array) $this->values as $value) {
-            $result = preg_match("/$this->regex/", $value);
-
-            if ($result !== 1) {
-                $errorCode = preg_last_error();
-
-                throw new InvalidRegexException("The value '{$value}' doesn't match pattern '{$this->regex}'. Failed with error code {$errorCode}.");
-            }
-        }
-    }
-
     public function formatJson(): Attributes
     {
         return $this->mergeJson(new Attributes([

diff --git a/tests/PhpPact/Consumer/Matcher/Matchers/EachValueTest.php b/tests/PhpPact/Consumer/Matcher/Matchers/EachValueTest.php
@@ -55,7 +55,7 @@ public function testFormatJson(): void
                         "value": null
                     }
                 ]
-                }
+            }
             JSON,
             $jsonEncoded
         );

diff --git a/tests/PhpPact/Consumer/Matcher/Matchers/RegexTest.php b/tests/PhpPact/Consumer/Matcher/Matchers/RegexTest.php
@@ -2,7 +2,6 @@
 
 namespace PhpPactTest\Consumer\Matcher\Matchers;
 
-use PhpPact\Consumer\Matcher\Exception\InvalidRegexException;
 use PhpPact\Consumer\Matcher\Exception\InvalidValueException;
 use PhpPact\Consumer\Matcher\Formatters\Expression\ExpressionFormatter;
 use PhpPact\Consumer\Matcher\Matchers\Regex;
@@ -14,17 +13,6 @@ class RegexTest extends TestCase
 {
     private string $regex = '\d+';
 
-    #[TestWith(['number', true])]
-    #[TestWith(['integer', false])]
-    public function testInvalidRegex(string $value, bool $isArray): void
-    {
-        $values = $isArray ? [$value] : $value;
-        $this->expectException(InvalidRegexException::class);
-        $value = is_array($values) ? $values[0] : $values;
-        $this->expectExceptionMessage("The value '{$value}' doesn't match pattern '{$this->regex}'. Failed with error code 0.");
-        new Regex($this->regex, $values);
-    }
-
     /**
      * @param string|string[]|null $values
      */