Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jit on windows #340

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Sep 22, 2023

The error I am trying to fix is:

[Fri Sep 22 04:21:58 2023] 127.0.0.1:65468 [500]: POST /pact-change-state - Uncaught UnexpectedValueException: JIT on Windows is not currently supported in D:\a\pact-php\pact-php\vendor\phpseclib\phpseclib\phpseclib\bootstrap.php:28

You need this PR to see the error clearly.

  • phpseclib doesn't support JIT on Windows, so I need to disable it.
  • I tried to set env PHPSECLIB_ALLOW_JIT but it seems does not work

@tienvx tienvx force-pushed the disable-jit-on-windows branch from 58eb453 to 9d28fb6 Compare September 27, 2023 15:18
This was referenced Sep 29, 2023
@tienvx tienvx force-pushed the disable-jit-on-windows branch from 9d28fb6 to 15046f4 Compare September 30, 2023 04:29
@JP-Ellis
Copy link
Contributor

Is there anything else preventing this from being merged?

@Lewiscowles1986
Copy link
Collaborator

@JP-Ellis who is that for? I Think this is good to go, as should be most one-liners that pass tests and are not complained about, loudly, very soon 😄

@JP-Ellis
Copy link
Contributor

In yesterday's Pact maintainer meetup, Tien mentioned that he was waiting on some of this PRs to be reviewed. As a result, I wanted to check if I could help. In doing so, I noticed that this PR was reviewed and approved, but still un-merged, and I was wanting to check whether there was any blockers.

@Lewiscowles1986
Copy link
Collaborator

Ah I'd approved as I'd commented, but it likely requires pact org members or folks with more permissions to additionally thumb. They might be busy, unless you can.

@YOU54F
Copy link
Member

YOU54F commented Oct 12, 2023

@tienvx doesn't have permission at the moment, (If I remember correctly, this was out of choice when you joined the maintainer group) - Happy to promote you when you are ready/happy 👍🏾

I have permissions across all the repos in the foundation to merge PR's but not overly familiar with every project so appreciate others reviews from those that use each particular library!

Thanks team - will look to get across a load of php and python PR's today :)

@YOU54F YOU54F merged commit 782c7dc into pact-foundation:ffi Oct 12, 2023
@tienvx tienvx deleted the disable-jit-on-windows branch October 13, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants