Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused code #708

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: Remove unused code #708

merged 1 commit into from
Dec 17, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 17, 2024 •
edited
Loading

I'm not sure how useful they are to the users of pact-php, but I think we can remove them, so that:

  • We don't have to maintain them
  • Remove some (dev) dependencies to make Github Actions's checking faster

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12364887860

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.313%
Totals Coverage Status
Change from base Build 12352232613: 0.0%
Covered Lines: 2560
Relevant Lines: 2658
💛 - Coveralls

@tienvx tienvx requested review from JP-Ellis and YOU54F December 17, 2024 02:15
@tienvx tienvx mentioned this pull request Dec 17, 2024
Merged
@tienvx tienvx merged commit b1437cc into pact-foundation:master Dec 17, 2024
20 checks passed
@tienvx tienvx deleted the remove-unused-code branch December 17, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis