Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tgz for bundled plugins #49

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Dec 7, 2023

closes #48

This feels like the code could be dry'd a bit, maybe doing a seperate file extension lookup, then checking the naming convention, then offloading to the correct downloader, but possibly fine for now.

can be tested by

[email protected]:pact-foundation/pact-plugins.git
git checkout feat/targz_plugin_binaries
cd cli
cargo run install https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.4

This will fail, is run from master or from the released binary

pact-plugin-cli install https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.4

Copy link

github-actions bot commented Dec 7, 2023

Unit Test Results

6 tests  ±0   6 ✔️ ±0   7s ⏱️ +2s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ±0 

Results for commit dd3359c. ± Comparison against base commit f57ddf3.

♻️ This comment has been updated with latest results.

@rholshausen
Copy link
Contributor

The JVM driver will need to be updated to support this as well.

@rholshausen rholshausen merged commit 375a0fd into main Dec 7, 2023
52 checks passed
@rholshausen rholshausen deleted the feat/targz_plugin_binaries branch December 7, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tgz compression for bundled plugins
2 participants