chore: add test for #850 #858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
=====================================
Coverage 78% 78%
=====================================
Files 30 30
Lines 3365 3369 +4
=====================================
+ Hits 2634 2638 +4
Misses 731 731
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JP-Ellis
force-pushed
the
chore/add-test-for-gh-850
branch
7 times, most recently
from
f3afb97
to
d935a23
Compare
4 tasks
JP-Ellis
force-pushed
the
chore/add-test-for-gh-850
branch
from
d935a23
to
0120ad9
Compare
Discoeverd by user-reported issue in #850. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/add-test-for-gh-850
branch
from
0120ad9
to
da3c9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add a test to catch the user-reported issue from #850, and hopefully add a fix to it.
🚨 Breaking Changes
Pending on investigation
🔥 Motivation
To ensure a consistent behaviour across platforms.
🔨 Test Plan
Add new test
🔗 Related issues/PRs