Skip to content

Commit

Permalink
chore: fix RSpec module name
Browse files Browse the repository at this point in the history
  • Loading branch information
bethesque committed Nov 4, 2020
1 parent e3e295f commit 4ccd174
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/pact/rspec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ def self.runner_defined?
end

def self.is_rspec_3
defined?(::Rspec) && ::RSpec::Core::Formatters.respond_to?(:register)
defined?(::RSpec) && ::RSpec::Core::Formatters.respond_to?(:register)
end

def self.is_rspec_2
defined?(::Rspec) && !is_rspec_3
defined?(::RSpec) && !is_rspec_3

This comment has been minimized.

Copy link
@iamvery

iamvery Nov 4, 2020

Contributor

👋 me again. I'm also getting an error in another app, that may be related to the RSpec work in the past couple commits. In particular I'm getting a NoMethodError for RSpec.configuration. In my env, the RSpec module actually ends up being a reference to the module defined in this file rather than the top-level RSpec. Do you have any ideas?

This comment has been minimized.

Copy link
@bethesque

bethesque Nov 25, 2020

Author Member

I think I've fixed this in the pact-ruby gem. Let me know if it's still an issue. I was trying to decouple pact support from rspec, as it's used in contexts that don't use RSpec (eg the mini-test pact gem).

This comment has been minimized.

Copy link
@iamvery

iamvery Nov 30, 2020

Contributor

Thank you for the update!

end

def self.with_rspec_3
Expand Down

0 comments on commit 4ccd174

Please sign in to comment.