Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to match integers and floats #38

Conversation

LindomarReitz
Copy link
Contributor

@LindomarReitz LindomarReitz commented Jul 22, 2017

The main idea here is to able to match integer/float values, not only strings.

It helps to validate more fields in the pact expectations, if necessary.

@bethesque
Copy link
Member

Hi,

Thanks for adding this, however, as pact is a multi-language implementation, we need to add changes like this to the pact specification, and add the equivalent functionality to the JVM/rust implementations as well.

@uglyog what do you think about using regular expressions on strings?

@uglyog
Copy link
Member

uglyog commented Jul 24, 2017

@bethesque regular expressions on strings will never work ;-)

I think you mean regular expressions on numbers? I'm happy to apply regular expressions to anything, converting them to strings for the comparison.

@bethesque
Copy link
Member

Yes. :%s/strings/numbers/.

Ok. @LindomarReitz how do you feel about adding some test cases to the latest pact-specification?

@YOU54F
Copy link
Member

YOU54F commented Apr 25, 2022

Thanks for this @LindomarReitz

Just picking up this thread, I believe this is done (in the pact-specification), looking at the above merge, and closes an outstanding issue in specification, details linked in

pact-foundation/pact-specification#39

are we there in terms of language support, I noted this was added to the v2 spec but the link in beths comment takes me to the v4 spec

@YOU54F
Copy link
Member

YOU54F commented Aug 14, 2024

closing in favour of #108

Thanks for your contribution

@YOU54F YOU54F closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants