[Test] Update create-test script for linting changes
#4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional boilerplate code Change prompt to be slightly more accurate
flx-sta
approved these changes
Oct 5, 2024
torranx
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
The test creation script would create a test with linting errors due to the recent linting change.
What are the changes from a developer perspective?
Updated the test creation script to take into account the new linting changes.
Added some extra boilerplate code that is likely to be common across tests.
Updated the test creation prompt to be clearer that you need to enter the name of the move/etc and not the name of the file (since the filename will be derived automatically by the script).
How to test the changes?
npm run create-testChecklist
betaas my base branch[ ] Have I considered writing automated tests for the issue?[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?[ ] Are all unit tests still passing? (npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?