-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Refactor Starter Species to use separate EggTier map #4591
Merged
DayKev
merged 7 commits into
pagefaultgames:beta
from
ben-lear:separate-egg-starter-tiers
Oct 10, 2024
Merged
[Enhancement] Refactor Starter Species to use separate EggTier map #4591
DayKev
merged 7 commits into
pagefaultgames:beta
from
ben-lear:separate-egg-starter-tiers
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madmadness65
added
Enhancement
New feature or request
Balance Team
Specifically a balance team change
labels
Oct 5, 2024
damocleas
previously approved these changes
Oct 5, 2024
DayKev
reviewed
Oct 5, 2024
…ear/pokerogue into separate-egg-starter-tiers
DayKev
approved these changes
Oct 5, 2024
ben-lear
added
the
Beta
Only present on Beta (didn't make it into production [yet])
label
Oct 6, 2024
torranx
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
damocleas
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Team
Specifically a balance team change
Beta
Only present on Beta (didn't make it into production [yet])
Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
No functional changes.
Why am I making these changes?
Creates a new Species
EggTier
map that can be used by Balance team to setEggTier
separately from a species' starter cost. Allows for situations like Regice, where it is still obtainable from Epic eggs as a sub-legendary but has starter cost of 5, etc.What are the changes from a developer perspective?
Not much changes, except an egg calculates its
EggTier
from thespeciesEggTier
map now instead of fromspeciesStarterCosts
.Also removed a redundant math clamping function in
utils.ts
How to test the changes?
Eggs are hatching with normal expected species. There are no balance changes in this PR.
Checklist
beta
as my base branchnpm run test
)