Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Refactor Starter Species to use separate EggTier map #4591

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

ben-lear
Copy link
Collaborator

@ben-lear ben-lear commented Oct 5, 2024

What are the changes the user will see?

No functional changes.

Why am I making these changes?

Creates a new Species EggTier map that can be used by Balance team to set EggTier separately from a species' starter cost. Allows for situations like Regice, where it is still obtainable from Epic eggs as a sub-legendary but has starter cost of 5, etc.

What are the changes from a developer perspective?

Not much changes, except an egg calculates its EggTier from the speciesEggTier map now instead of from speciesStarterCosts.

Also removed a redundant math clamping function in utils.ts

How to test the changes?

Eggs are hatching with normal expected species. There are no balance changes in this PR.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added Enhancement New feature or request Balance Team Specifically a balance team change labels Oct 5, 2024
@ben-lear ben-lear marked this pull request as ready for review October 5, 2024 20:59
@ben-lear ben-lear requested a review from a team as a code owner October 5, 2024 20:59
damocleas
damocleas previously approved these changes Oct 5, 2024
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/data/balance/species-egg-tiers.ts Outdated Show resolved Hide resolved
@ben-lear ben-lear added the Beta Only present on Beta (didn't make it into production [yet]) label Oct 6, 2024
Copy link
Contributor

@torranx torranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DayKev DayKev requested a review from damocleas October 8, 2024 14:27
@DayKev DayKev merged commit 6ad5ba9 into pagefaultgames:beta Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change Beta Only present on Beta (didn't make it into production [yet]) Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants