Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta][P3] fix i18n namespaceMap for mystery-encounter-texts -> mysteryEncounterMessages #4617

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Oct 8, 2024

Tip

Something I missed in #4611

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?

@flx-sta flx-sta added P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. Beta Only present on Beta (didn't make it into production [yet]) labels Oct 8, 2024
@flx-sta flx-sta marked this pull request as ready for review October 8, 2024 17:37
@flx-sta flx-sta requested a review from a team as a code owner October 8, 2024 17:37
@flx-sta flx-sta changed the title [Beta][P3] fix i18n namespaceMap for mysery-encounter-texts -> mysteryEncounterMessages [Beta][P3] fix i18n namespaceMap for mystery-encounter-texts -> mysteryEncounterMessages Oct 8, 2024
@Tempo-anon Tempo-anon merged commit d8c914c into pagefaultgames:beta Oct 8, 2024
13 checks passed
@flx-sta flx-sta deleted the bug/beta/me-messages-texts branch October 8, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Only present on Beta (didn't make it into production [yet]) P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants