Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Proof of Concept - Transfer held items from released Party Pokemon to new Pokemon #4788

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

frutescens
Copy link
Contributor

@frutescens frutescens commented Nov 4, 2024

What are the changes the user will see?

The user will be able to automatically transfer the released Party Pokemon's items to the newly caught Pokemon as long as the added items are within the stack limit + the released Pokemon has a certain friendship

Why am I making these changes?

Felt like it. If Balance approves/requests changes/rejects, then I will accept. Not super attached to this PR's outcome.

What are the changes from a developer perspective?

Very messed up stuff.
Item transfer only allowed if both Pokemon are allowed in challenges.

Screenshots/Videos

freecompress-Screen.Recording.2024-11-03.at.9.33.58.PM.mp4

How to test the changes?

  • Have a Pokemon with items in your party + a full party
  • Catch a Pokemon
  • Replace the Pokemon with items with the new Pokemon
  • Pokemon Held Items should transfer over

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@frutescens frutescens requested a review from a team as a code owner November 4, 2024 05:35
@frutescens frutescens added Enhancement New feature or request Game Balance Changes focused on game balance Balance Team Specifically a balance team change labels Nov 4, 2024
@frutescens frutescens changed the title [QoL] Transfer held items from released Party Pokemon to new Pokemon [QoL] Proof of Concept - Transfer held items from released Party Pokemon to new Pokemon Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change Enhancement New feature or request Game Balance Changes focused on game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant