Beta -> Main 1.2.0 update #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main -> Beta (1.1.6)
* implementing friend guard ability * Update src/data/ability.ts Co-authored-by: NightKev <[email protected]> * Update src/data/ability.ts Co-authored-by: NightKev <[email protected]> * Update src/data/ability.ts Co-authored-by: NightKev <[email protected]> * Update src/test/abilities/friend_guard.test.ts Co-authored-by: NightKev <[email protected]> * Update src/field/pokemon.ts Co-authored-by: innerthunder <[email protected]> * more tests and fixing other issues * more tests and fixing other issues * Update Friend Guard test with damage mocks --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: innerthunder <[email protected]> Co-authored-by: innerthunder <[email protected]>
) * [BUG] Added frenzy reset function during move phase should move be cancelled (#4227) * Revert [P2 BUG] Fix since it does not work and is faulty * [P2 BUG] Implemented correct frenzy Tag and Movequeue reset should frenzy move fail (#4277) * Cleaned up Bug Fix using frenzyMissFunc * Added automated test case for frenzy move edge case * Improvement to frenzy move reset test case speed * Fix test * Add missing import --------- Co-authored-by: NightKev <[email protected]>
…icry (#4682) * addedType variable * basic mimicry implementation * eslint * rage * quick change * made files * added mimicry activation message * test for moves done * hahahhaha * done? for now? * laklhaflhasd * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> * time to start... ughhh * reflect type * Added new message * Update src/field/pokemon.ts Co-authored-by: PigeonBar <[email protected]> * Update src/data/ability.ts Co-authored-by: flx-sta <[email protected]> * added overrides * some checks * removed comments * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: NightKev <[email protected]> Co-authored-by: PigeonBar <[email protected]> Co-authored-by: flx-sta <[email protected]>
* Change Bouncy Bubble's Healing * Move comment to what is custom about Bouncy Bubble --------- Co-authored-by: damocleas <[email protected]>
* Fixing form name being incorrect for some evolved pokemon * Updated to include showing the root speciesId if the speciesId locale key doesn't exist
* Chloroblast & Struggle should not recoil if no damage was dealt * Protect against missing move entry Co-authored-by: PigeonBar <[email protected]> --------- Co-authored-by: PigeonBar <[email protected]>
…ed In, and When a Pokemon Fails to Escape #4353 (#4676) * fixing speed boost for pokemon being switched in and for if failed escape * adding unit tests * adding failed run away test case * adding failed run away test case modification * refactoring solution to be more consistent with coding style * more fixes for consistency * more fixes for consistency * adding new AbAttr in abiliity.ts for posterity * removing uneccesary variables * fixing a merge conflict
#4687) * fixing the exp bug * fixing the exp bug * dont think need to reset turn data there * changing a little bit * Update src/phases/faint-phase.ts Co-authored-by: innerthunder <[email protected]> --------- Co-authored-by: innerthunder <[email protected]>
Co-authored-by: frutescens <info@laptop>
* Update and rename statuses_es.json to statuses_es-ES.json * Rename statuses_es.png to statuses_es-ES.png * Update and rename types_es.json to types_es-ES.json * Rename types_es.png to types_es-ES.png * Update i18n.ts * Update settings.ts * Update settings-display-ui-handler.ts * Update starter-select-ui-handler.ts * Update utils.ts * Update settings-display-ui-handler.ts * Update loading-scene.ts * Update timed-event-manager.ts * change remaining 'es' to 'es-ES' in various UIs * change halloween event banner from es to es-ES * update to latest locale commit --------- Co-authored-by: Moka <[email protected]>
…4643) * Wild mons can't flee with U-turn * Update src/data/move.ts Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: NightKev <[email protected]>
…4775) * disable timed events in tests * Take weight into account when getting the tier of modifiers * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> Co-authored-by: PigeonBar <[email protected]> --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: PigeonBar <[email protected]>
* the fix... will maybe write a test later * ughh * made a test * moved aorund function * Update src/test/moves/camouflage.test.ts Co-authored-by: PigeonBar <[email protected]> * lalal --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: PigeonBar <[email protected]>
* Optional parameter interfaces for `MoveEffectAttr` and `StatStageChangeAttr` * Update docs + Diamond Storm typo * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> * Make move effect trigger specification optional --------- Co-authored-by: NightKev <[email protected]>
* Re-structured MoveEffectPhase.run() to reduce nesting and improve readability. * Re-structured MoveEffectPhase.run() to reduce nesting and improve readability. * Added Substitute Implementation * Fix indentation, tsdocs, add `public`/etc * Prevent ENEMY_SIDE targeted moves from occurring twice in double battles * Add `override` to `start()` and `end()` * Minor indentation fix --------- Co-authored-by: innerthunder <[email protected]> Co-authored-by: NightKev <[email protected]>
* Setting species-variables to read only * set generations to protected * formIndex set to protected * quick fix * typedocs fixes * get / set generation * wait * Use get/set for formIndex too * Fix misplaced line * Replace a couple `!!` with default params --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: NightKev <[email protected]> Co-authored-by: Tempoanon <[email protected]>
…Armoa Veil ignorable (#4778) Co-authored-by: frutescens <info@laptop>
* implement Wimp Out/Emergency Exit * fixed test * fixed weather bug * Added nightmare interaction to Wimp Out following bug fix * refactored and added postdamageattr * bug fixes * added confusion test back (skipped) * updated applyPostDamageAbAttrs to applyPostDamage * fix external func name * fixed syntax inconsistency * updated PostDamageForceSwitchAttr -> PostDamageForceSwitchAbAttr * Modify `wimp_out.test.ts` * remove extra comment Co-authored-by: NightKev <[email protected]> * remove extra comment Co-authored-by: NightKev <[email protected]> * Update tsdocs Co-authored-by: NightKev <[email protected]> * remove comment Co-authored-by: NightKev <[email protected]> * remove comment Co-authored-by: NightKev <[email protected]> * fix tsdocs Co-authored-by: NightKev <[email protected]> * fix tsdocs Co-authored-by: NightKev <[email protected]> * fix tsdocs Co-authored-by: NightKev <[email protected]> * fix tsdocs Co-authored-by: NightKev <[email protected]> * fix whitespace Co-authored-by: NightKev <[email protected]> * make getFailedText public Co-authored-by: NightKev <[email protected]> * make switchOutLogic public Co-authored-by: NightKev <[email protected]> * make getSwitchOutCondition public Co-authored-by: NightKev <[email protected]> * make getFailedText public Co-authored-by: NightKev <[email protected]> * make applyPostDamage public Co-authored-by: NightKev <[email protected]> * simplify if statement Co-authored-by: NightKev <[email protected]> * add public override to applyPostDamage Co-authored-by: NightKev <[email protected]> * fixed nested if issue, remove trapped tag removal * add fix for multi hit move * added multi-lens logic * moved applyPostDamageAbAttrs to pokemon.damage, added check for multi lens in pokemon.apply * added source to damageAndUpdate and applyPostDamageAbAttrs, added Parental Bond logic + test, put applyPostDamageAbAttrs back in damageAndUpdate * simplify multi hit check Co-authored-by: innerthunder <[email protected]> * Minor formatting changes * Update src/data/ability.ts Co-authored-by: NightKev <[email protected]> * moved and renamed shouldPreventSwitchOut, rewrote tests to account for U-turn changes, fix syntax error * Move comment slightly --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: innerthunder <[email protected]>
* Added double battle exclusion to Endless bosses. * Brought Endure token RNG in line with game RNG formatting. * Corrected incorrect modulo condition in isEndlessBoss * Moved new doubles conditional to be above overrides. * Fixed bad RNG calls for Covet and Thief too. * Updated unburden test. * Revert "Updated unburden test." This reverts commit 01788d4. * Revert "Fixed bad RNG calls for Covet and Thief too." This reverts commit c7fcfd1. --------- Co-authored-by: frutescens <info@laptop>
This includes Sunsteel Strike, Moongeist Beam and Photon Geyser
…battles (#4873) * Add failsafe to Commander remove anim * Commanded tag saves Tatsu form on reload
…ja, Rival starter HA (#4863) * Remove Pika/Eevee forms from Trainers before wave 30, and BB Gren * Fix `egg` test * Ban hidden ability from Rival starter --------- Co-authored-by: NightKev <[email protected]>
…4842) * Set default fps to 10 instead of 12 for pokemon sprites * [Sprite] Set pokemon animation framerate to 10 where assigned
* Added Freeze to statuses healed by Jungle Healing / Lunar Blessing * Fixed up documentation. --------- Co-authored-by: frutescens <info@laptop>
…4849) * Added more intelligent cursor memory for target selection in Doubles * Added documentation * Fixed variable name. * Apply suggestions from code review Co-authored-by: Moka <[email protected]> --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: Moka <[email protected]>
…c Gold (#4856) * Increase Gimmighoul's evo counter more with Big Nugget/Relic Gold * Update src/modifier/modifier.ts Co-authored-by: Moka <[email protected]> --------- Co-authored-by: Moka <[email protected]>
* Endure Tokens only endure one hit * Add tests for Endure * Update docs --------- Co-authored-by: NightKev <[email protected]>
…waves (#4808) * Replaced conditional with `true` so that sync-to-server occurs at the start of every wave. * Update src/phases/encounter-phase.ts Co-authored-by: Frederico Santos <[email protected]> * Fixed errors from previous commit. * Revised condition to include the first wave of a run. * Apply suggestions from code review Co-authored-by: Moka <[email protected]> --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: Frederico Santos <[email protected]> Co-authored-by: Moka <[email protected]>
* [P1] Fix System Data Conversion Failure 3 * Use `isNullOrUndefined`, Clean Up Imports * fix pre candy update save data migration for candy * fix pre candy update save data migration for candy part 2... --------- Co-authored-by: Moka <[email protected]>
#4858) * Moved code preventing MBH's transfer to after enemy modifiers were generated. * Removed unnecessary ! * Removed unnecessary ? * Created a new enum and functions for retrieving final bosses. * Moved isBattleClassicFinalBoss to game-mode.ts and reverted battle.ts * Preventing item transfer with tryTransferModifier instead * Added filtering to modifier-retrieve methods. * Revised logic in tryTransferHeldItemModifier * Adding what works to the game even though it's not the best. * Added comments * Removing past changes to files. * Added check for Classic Final Boss. --------- Co-authored-by: frutescens <info@laptop>
…4801) * fix training session encounter not applying nature correctly * implement pokemon.setCustomNature + nature unlock utility method(s) * update doc --------- Co-authored-by: Moka <[email protected]>
* [P3] Prevent Unintended ME Migration Application * Change Patch Value from 4 to 5 * Bump Game Version * Fix Imports, Use `isNullOrUndefined`
frutescens
previously approved these changes
Nov 17, 2024
Co-authored-by: frutescens <info@laptop>
* Changed conditional to actually consider the wave index. * Added PigeonBar's test * Added check for MEs + Documentation * Apply suggestions from code review Co-authored-by: PigeonBar <[email protected]> --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: PigeonBar <[email protected]>
Tempo-anon
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024/11/17 The Carpe Diem Update
Major Changes
Minor Changes
Implementations and Fixes
Implementations
Moves
Abilities
Fixes and Changes to Moves and Abilities
Items
QOL
Other Bug Fixes