Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Localizable Event Timer #4971

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Dec 5, 2024

What are the changes the user will see?

If you not play in English and if a translation is available, so the event timer will display in the right language

Why am I making these changes?

To have it opened to translation

What are the changes from a developer perspective?

None

Screenshots/Videos

Example in French:
image

How to test the changes?

Set an Event in src/timed-event-manager covering you current date to display the timer and then play with the locales

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

@Adri1 Adri1 added the Localization Provides or updates translation efforts label Dec 5, 2024
@Adri1 Adri1 requested a review from a team as a code owner December 5, 2024 00:55
@DayKev DayKev merged commit f2ef362 into pagefaultgames:beta Dec 7, 2024
13 checks passed
@Adri1 Adri1 deleted the event-timer-localization branch December 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants