[UI/UX] Spend all button for gacha #5136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madmadness65
added
Enhancement
DayKev
reviewed
Jan 18, 2025
DayKev
reviewed
Jan 18, 2025
|
Got back home just in time to see locales get merged nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Add a new spend all button in the egg gacha so that when I want to buy max eggs I don't have to hold the z key down for two minutes on the voucher plus icon
Why am I making these changes?
Buying max egg inventory on the gacha currently is a bit boring. New button added changes the experience from a 2 minute youtube break with the z key held down to a single button press.
What are the changes from a developer perspective?
Some new lines in locale to translate because existing messages don't describe exactly accurately some of the new behavior, egg gacha UI shifted around a little to make room for the new option and removed a seemingly redundant instantiation of
this.eggGachaOptionsContainerthat isn't necessarily relevant to the content of the PR. Attempts to use highest denomination vouchers first. Maybe could be given a new icon. If the one redundant line I took out was important or we want to split that out I can take it out of this PR.Screenshots/Videos
How to test the changes?
Click the new all button with vouchers added to inventory.
Checklist
betaas my base branchnpm run test)npm run create-test) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: