Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Login Screen Buttons can be Pressed While Animating #5170

Open
wants to merge 6 commits into
base: beta
Choose a base branch
from

Conversation

ChrisLolz
Copy link
Contributor

@ChrisLolz ChrisLolz commented Jan 23, 2025

What are the changes the user will see?

  • When pressing the enter key or clicking the login screen buttons rapidly, the outside buttons will no longer go upwards.
  • The login buttons will only work when the screen has finished animating
  • Prevents closing the rename Pokemon screen while the UI is still moving.

Why am I making these changes?

Mainly to fix #5163

What are the changes from a developer perspective?

  • Added to check to see if the container still has tweens remaining in the action listeners of FormModalUiHandler, LoginFormUiHandler, ModalUiHandler, and RegistrationFormUiHandler.
  • Moved the creation of infoContainer into its own function to make setup more clean since ExternalPartyContainer is created on its own function already.

Screenshots/Videos

You can't really tell but I am spamming enter and clicking in these videos
Login screen:

login.mp4

Register screen:

register.mp4

Gear icon:

gear.mp4

Renaming Pokemon

rename.mp4

How to test the changes?

I'm unable to host my own local server so I just changed line 30 and 31 to true of login-phase.ts to force the login screen. Otherwise just test manually by clicking the buttons.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@ChrisLolz ChrisLolz requested a review from a team as a code owner January 23, 2025 19:47
@DayKev DayKev added the UI/UX User interface/-experience related label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Login Screen Buttons can be Pressed While Animating
2 participants