[Bug] Fix Login Screen Buttons can be Pressed While Animating #5170
+111
−97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Why am I making these changes?
Mainly to fix #5163
What are the changes from a developer perspective?
FormModalUiHandler
,LoginFormUiHandler
,ModalUiHandler
, andRegistrationFormUiHandler
.infoContainer
into its own function to make setup more clean sinceExternalPartyContainer
is created on its own function already.Screenshots/Videos
You can't really tell but I am spamming enter and clicking in these videos
Login screen:
login.mp4
Register screen:
register.mp4
Gear icon:
gear.mp4
Renaming Pokemon
rename.mp4
How to test the changes?
I'm unable to host my own local server so I just changed line 30 and 31 to true of
login-phase.ts
to force the login screen. Otherwise just test manually by clicking the buttons.Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: