[Bug][Ability] Fix wimp out and emergency exit skipping waves in double battles

[SirzBenjie]

What are the changes the user will see?

Emergency Exit and Wimp Out will no longer open an alternate dimension and skip waves when a pokemon with wimp out's ability triggers in response to a spread move that causes its teammates to faint.

Why am I making these changes?

Fixes #5032

What are the changes from a developer perspective?

Inside the start method of NewBattlePhase and EndBattlePhase, the first thing that is done after the call to super() is to filter out the phase queue (and prependPhaseQueue) to clear out any extra phases that have been added.

This ends up being defensive programming. Rather than adding convoluted checks at the places where NewBattlePhase and EndBattlePhase occur to determine whether or not they should properly occur is

Screenshots/Videos

Fixed Wimp Out

wimp_out_fixed.mp4

Old behavior on #5032

How to test the changes?

Go into a new battle with this override set:

  BATTLE_TYPE_OVERRIDE: "double",
  STARTING_LEVEL_OVERRIDE: 4,
  OPP_LEVEL_OVERRIDE: 3,
  MOVESET_OVERRIDE: [Moves.DRAGON_ENERGY, Moves.GASTRO_ACID, Moves.METAL_SOUND],
  OPP_SPECIES_OVERRIDE: Species.WIMPOD,
  OPP_MOVESET_OVERRIDE: [Moves.SPLASH]

Follow the steps in the video depicted in #5032

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• [ ] Has a locales PR been created on the locales repo?
  • ~~[ ] If so, please leave a link to it here: ~~
• [ ] Has the translation team been contacted for proofreading/translation?

[Wlowscha]

Could you also take a look at #4950 just in case it also gets fixed by this? It's most likely a different problem, but just to be sure.

[SirzBenjie]

Could you also take a look at #4950 just in case it also gets fixed by this? It's most likely a different problem, but just to be sure.

I didn't investigate the cause, but I just tested and can confirm that this PR does not fix that bug.

[DayKev]

Could you also take a look at #4950 just in case it also gets fixed by this? It's most likely a different problem, but just to be sure.

Yeah that's a different issue, from switch-summon-phase.ts, that would be fixed with something like this: