Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overrun in printable_binary. #34

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Fix buffer overrun in printable_binary. #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libpagekite/pkutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,10 @@ int printable_binary(char* dest, size_t dlen, const char* src, size_t slen)
*dest++ = '\0';
return copied;
}
int wrote = sprintf(dest, "\\x%2.2x", *p);
/* The cast to unsigned char is required, otherwise 'negative' byte
* values will be sign-extended to int and will take more than four
* bytes; e.g. 255 is printed as \xffffffff */
int wrote = sprintf(dest, "\\x%2.2x", (unsigned char) *p);
dest += wrote;
dlen -= wrote;
}
Expand Down