Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1939] - Use self hosted runner #1174

Merged
merged 12 commits into from
Oct 3, 2024

Conversation

christian-calabrese
Copy link
Contributor

@christian-calabrese christian-calabrese commented Oct 2, 2024

List of Changes

Implemented the AWS resources needed to employ AWS CodeBuild as a Github self-hosted runner

Motivation and Context

A self-hosted runner was an highly needed feature for the developer portal.
The reasons are the following:

  • High demanding disk usage during nextjs-website builds
  • Secure network reachability to private resources as the chatbot redis instance for indexing
  • Possibility to scale the runner capabilities

How to adopt it:

In order to run a Github action step in a codebuild container, please replicate this change in the workflow file:

For the dev environment:
runs-on: codebuild-dev-github-runner-${{ github.run_id }}-${{ github.run_attempt }}

For the prod environment:
runs-on: codebuild-prod-github-runner-${{ github.run_id }}-${{ github.run_attempt }}

If you are running a step in a matrix cycle:
runs-on: codebuild-${{ matrix.environment }}-github-runner-${{ github.run_id }}-${{ github.run_attempt }}

How Has This Been Tested?

This step has been actually executed on the codebuild environment
https://github.com/pagopa/developer-portal/actions/runs/11145619001/job/30979461133

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 30f034b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
infrastructure Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Branch is not up to date with base branch

@christian-calabrese it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Bundle not found for branch main.
It wasn't possible to compare bundles size.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1939

Copy link
Contributor

@mamu0 mamu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-calabrese christian-calabrese merged commit 064366d into main Oct 3, 2024
11 checks passed
@christian-calabrese christian-calabrese deleted the dev-1939-use-self-hosted-runner branch October 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants