Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAI-182] fix(chatbot): api gateway permits DELETE requests #1195

Merged
merged 2 commits into from
Oct 13, 2024
Merged

[CAI-182] fix(chatbot): api gateway permits DELETE requests #1195

merged 2 commits into from
Oct 13, 2024

Conversation

batdevis
Copy link
Collaborator

@batdevis batdevis commented Oct 11, 2024 •
edited
Loading

List of Changes

added DELETE to allowed methods list in api gateway

Motivation and Context

We have a DELETE API.

@batdevis batdevis requested a review from a team as a code owner October 11, 2024 08:03
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9d797be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@batdevis batdevis changed the title fix(chatbot): api gateway permits DELETE requests [CAI-182] fix(chatbot): api gateway permits DELETE requests Oct 11, 2024
christian-calabrese
christian-calabrese approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@christian-calabrese christian-calabrese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 13, 2024 •
edited by jira bot
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue CAI-182

@batdevis batdevis merged commit dcb7f89 into main Oct 13, 2024
13 checks passed
@batdevis batdevis deleted the chatbot/fix-delete-cors branch October 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-calabrese christian-calabrese christian-calabrese approved these changes

Assignees

@batdevis batdevis

Labels
infra size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@batdevis @christian-calabrese